code-423n4 / 2022-05-rubicon-findings

5 stars 2 forks source link

Upgraded G -> M from 84 [1656428843011] #516

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Judge has assessed an item in Issue #84 as Medium risk. The relevant finding follows:

HickupHH3 commented 2 years ago

https://github.com/code-423n4/2022-05-rubicon/blob/main/contracts/RubiconMarket.sol#L471 Function isClosed: If this is meant to be hardcoded as false then better use a variable

dup of #148