search

code-423n4 / 2022-05-rubicon-findings

5 stars 2 forks source link

Upgraded G -> M from 49 [1656600225781] #517

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Judge has assessed an item in Issue #49 as Medium risk. The relevant finding follows:

HickupHH3 commented 2 years ago

L467 - isClosed() always returns false, so there is no point in validating it in require((msg.sender == getOwner(id)) || isClosed()).

L573 - isClosed() always returns false, so there is no point in validating it in require(isClosed() || msg.sender == getOwner(id) || id == dustId).

dup of #148