search

code-423n4 / 2022-05-velodrome-findings

0 stars 0 forks source link

Upgraded Q -> M from 95 [1657055392912] #225

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Judge has assessed an item in Issue #95 as Medium risk. The relevant finding follows:

GalloDaSballo commented 2 years ago

It would be good to add one more require() for _fantomSender. contracts\redeem\RedemptionReceiver.sol#L44 If _fantomSender is zero address, then it will be considered as non-initialized even after successful deposit. You need to insert below code at #L45. require(_fantomSender != address(0), "ZERO ADDRESS");

GalloDaSballo commented 2 years ago

Dup of https://github.com/code-423n4/2022-05-velodrome-findings/issues/36