code-423n4 / 2022-05-vetoken-findings

1 stars 1 forks source link

Upgraded Q -> M from 9 [1659036743700] #273

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Judge has assessed an item in Issue #9 as Medium risk. The relevant finding follows: Centralized risk The operator address can mint arbitrary amount of tokens. In addition, operator can also burn tokens from third-party accounts.

If the private key of the owner or minter address is compromised, the attacker will be able to mint an unlimited amount of tokens, or burn from arbitrary addresses.

operator can mint and burn arbitrary tokens. I believe this is unnecessary and poses a serious centralization risk.

Recomendation:

Consider reduce centralization risks with timelock contracts. Affected source code:

VE3Token.sol#L26-L36 VeToken.sol#L23-L33 DepositToken.sol#L26-L36

JeeberC4 commented 2 years ago

Duplicate of #202