QA Report - Githubissues

code-423n4 / 2022-06-badger-findings

0 stars 0 forks source link

QA Report #117

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Unused named return value in `checkUpkeep()`

performData is not used inside the function
https://github.com/Badger-Finance/vested-aura/blob/v0.0.2/contracts/MyStrategy.sol#L385-L388

function checkUpkeep(bytes calldata checkData) external view returns (bool upkeepNeeded, bytes memory performData) {
        (, uint256 unlockable, ,) = LOCKER.lockedBalances(address(this));
        upkeepNeeded = unlockable > 0;
    }

GalloDaSballo commented 2 years ago

It is unused but needed by Chainlink's interface