search

code-423n4 / 2022-06-badger-findings

0 stars 0 forks source link

QA Report #36

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

  1. Missing event and emit manualSetDelegate() should have an event call when changing the delegation to another address setBribesProcessor() should have an event call when changing the BribesProcessor to another address setProcessLocksOnReinvest() is missing and event and emit

  2. Missing zero address check manualSetDelegate() for delegate parameter

  3. Unused functions _withdrawAll() seems to be missing some follow up code or logic, as it only does a require check prepareWithdrawAll()

  4. manualProcessExpiredLocks() can/should have internal mutability instead

GalloDaSballo commented 2 years ago

Disagree with the findings in lack of details