search

code-423n4 / 2022-06-badger-findings

0 stars 0 forks source link

QA Report #42

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Low-Risk Issues

  1. safeApprove() is deprecated, use safeIncreaseAllowance() and safeDecreaseAllowance() instead Reference: L-05 https://code4rena.com/reports/2022-04-backd contracts\MyStrategy.sol#L65-L68

Non-critical Issues

  1. Open TODOs contracts\MyStrategy.sol#L284 contracts\MyStrategy.sol#L422

  2. Unused variable "performData" contracts\MyStrategy.sol#L385 contracts\MyStrategy.sol#L391

GalloDaSballo commented 2 years ago

Yes but we used safeApprove the correct way, once and from 0 to X