QA Report

[code423n4]

1. Unused local variables, function parameters

• In getBorrowRate, the paramters uint cash, uint borrows, uint reserves are not used inside the function.
• in NoteInterest.sol#L109, uint reserveFactorMantissa parameter is unsused.

2. Unused modifier

• The modifer OnlyUniGov is not used anywher inside the contract Proposal-Store.sol

3. Misleading/Random comments

• https://github.com/Plex-Engineer/manifest/blob/688e9b4e7835854c22ef44b045d6d226b784b4b8/contracts/Proposal-Store.sol#L6-L7
• The comments may be misleading in Proposal-Store.sol

4. function visibility can be restricted to pure and view

• function redeemVerify()'s visibility can be changed to pure

• function liquidateBorrowAllowed() visibility can be changed to view

  5. Add proper revert string in require()

• https://github.com/Plex-Engineer/lending-market/blob/b93e2867a64b420ce6ce317f01c7834a7b6b17ca/contracts/Treasury/TreasuryDelegate.sol#L16-L17

6. No events emitted for important updates

• https://github.com/Plex-Engineer/lending-market/blob/b93e2867a64b420ce6ce317f01c7834a7b6b17ca/contracts/WETH.sol#L32
• https://github.com/Plex-Engineer/lending-market/blob/b93e2867a64b420ce6ce317f01c7834a7b6b17ca/contracts/WETH.sol#L24
• The event emits are commented but it's a good practice to emit event for important actions like deposit() and withdraw()

7. allowance(address owner, address spender) in WETH.sol returns 0 always

• https://github.com/Plex-Engineer/lending-market/blob/b93e2867a64b420ce6ce317f01c7834a7b6b17ca/contracts/WETH.sol#L103-L104
• It's missing keyword return

  // recommendation
  function allowance(address owner, address spender) external view returns (uint256) {
      return _allowance[owner][spender];
  }

[GalloDaSballo]

1. Unused local variables, function parameters

Valid NC

2. Unused modifier

Valid Refactoring

3. Misleading/Random comments

Valid NC

4. function visibility can be restricted to pure and view

Valid Ref

5. Add proper revert string in require()

Valid NC

6. No events emitted for important updates

Valid NC

7. allowance(address owner, address spender) in WETH.sol returns 0 always

Valid Low

TODO -> Bump Allowance

Neat report, great format

1L 2R 4NC