code-423n4 / 2022-06-canto-findings

0 stars 0 forks source link

QA Report #38

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

[L-01] It's not possible for msg.sender to equal address(0)

https://github.com/Plex-Engineer/lending-market/blob/755424c1f9ab3f9f0408443e6606f94e4f08a990/contracts/Governance/GovernorBravoDelegate.sol#L164

[N-01] Add to in mint() event emission similar to burn()

https://github.com/Plex-Engineer/stableswap/blob/489d010eb99a0885139b2d5ed5a2d826838cc5f9/contracts/BaseV1-core.sol#L257

[N-02] Consants should be all caps

https://github.com/Plex-Engineer/lending-market/blob/755424c1f9ab3f9f0408443e6606f94e4f08a990/contracts/Governance/GovernorBravoDelegate.sol#L9-L12

[N-03] Interfaces should start with "I"

https://github.com/Plex-Engineer/lending-market/blob/755424c1f9ab3f9f0408443e6606f94e4f08a990/contracts/Governance/GovernorBravoDelegate.sol#L30

[N-04] External/public functions should not start with "_". Reserved for internal/private functions.

https://github.com/Plex-Engineer/lending-market/blob/755424c1f9ab3f9f0408443e6606f94e4f08a990/contracts/Governance/GovernorBravoDelegate.sol#L162 https://github.com/Plex-Engineer/lending-market/blob/755424c1f9ab3f9f0408443e6606f94e4f08a990/contracts/Accountant/AccountantDelegator.sol#L42 https://github.com/Plex-Engineer/lending-market/blob/755424c1f9ab3f9f0408443e6606f94e4f08a990/contracts/Treasury/TreasuryDelegator.sol#L29

[N-05] Extra space in parameters

https://github.com/Plex-Engineer/lending-market/blob/755424c1f9ab3f9f0408443e6606f94e4f08a990/contracts/Accountant/AccountantDelegator.sol#L54

GalloDaSballo commented 2 years ago

[L-01] It's not possible for msg.sender to equal address(0)

Comp engineers are prepared for the downfall of secp256k1

Valid Refactoring

[N-01] Add to in mint() event emission similar to burn()

NC

[N-02] Consants should be all caps

Valid Ref

[N-03] Interfaces should start with "I"

Valid Ref

[N-04] External/public functions should not start with "_". Reserved for internal/private functions.

Valid Ref

[N-05] Extra space in parameters

Valid NC

4 R 2 NC