code-423n4 / 2022-06-canto-v2-findings

0 stars 0 forks source link

Upgraded Q -> M from 113 [1660684075488] #183

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Judge has assessed an item in Issue #113 as Medium risk. The relevant finding follows:

GalloDaSballo commented 2 years ago

L05: commented out deadline check in BaseV1Router01 BaseV1-periphery.sol:87

modifier ensure(uint deadline) { //require(deadline >= block.timestamp, "BaseV1Router: EXPIRED"); The deadline is used to prevent the transaction to be withhold and to be used later. However the modifier's line to check the deadline is commented out.

GalloDaSballo commented 2 years ago

Dup of #90