code-423n4 / 2022-06-canto-v2-findings

0 stars 0 forks source link

QA Report #50

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

SafeMath is not needed when using Solidity version 0.8. This contracts version 0.8.10 which already implements overflow checks by default. At the same time, it uses the SafeMath library from OpenZeppelin which is more gas expensive than the 0.8. overflow checks.

https://github.com/Plex-Engineer/lending-market-v2/blob/2646a7676b721db8a7754bf5503dcd712eab2f8a/contracts/NoteInterest.sol https://github.com/Plex-Engineer/lending-market-v2/blob/2646a7676b721db8a7754bf5503dcd712eab2f8a/contracts/Timelock.sol

GalloDaSballo commented 2 years ago

Valid R