search

code-423n4 / 2022-06-connext-findings

1 stars 0 forks source link

QA Report #192

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

reimburseRelayerFees() will error if den = 0

reimburseRelayerFees will error if den = 0, this will happen because den is the divisor. And the

sponsoredFee = (_originRelayerFee * num) / den;

and sponsorFee is calculated twice at line 246 and 253. i suggest to remove the code in line 246.

https://github.com/code-423n4/2022-06-connext/blob/main/contracts/contracts/core/connext/helpers/SponsorVault.sol#L234

jakekidd commented 2 years ago

Duplicate of https://github.com/code-423n4/2022-06-connext-findings/issues/189