QA Report

[code423n4]

Low Risk Issues

• Wrong implementation of PortalFacet.getAavePortalFeeDebt(). contracts\core\connext\facets\PortalFacet.sol#L38-L40

• Different validations of adminFee and swapFee. contracts\core\connext\helpers\StableSwap.sol#L97-98 contracts\core\connext\libraries\SwapUtils.sol#L1071 contracts\core\connext\libraries\SwapUtils.sol#L1084

• Recommend to use safeIncreaseAllowance(), safeDecreaseAllowance() as safeApprove() is deprecated. contracts\core\connext\libraries\AssetLogic.sol#L347

• Wrong comments contracts\core\connext\helpers\StableSwap.sol#L223 contracts\core\connext\helpers\StableSwap.sol#L227 contracts\core\connext\helpers\StableSwap.sol#L240 contracts\core\connext\libraries\SwapUtils.sol#L790 contracts\core\connext\libraries\LibConnextStorage.sol#L299

[jakekidd]

• Needs more details, how is implementation "wrong"?
• Invalid: Looking at SwapUtils, this seems correct... adminFee should take a portion of swapFee, they are not the same.
• approval needs to be reset to 0 and then increased, so we are stuck using safeApprove method in order to do so
• Again, needs more details? how are comments "wrong" exactly?

very little to work with here in comparison to other QA reports