search

code-423n4 / 2022-06-connext-findings

1 stars 0 forks source link

QA Report #244

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

1. Open TODOs

Code architecture, incentives, and error handling/reporting questions/issues should be resolved before deployment

Examples of this issue in the codebase:

  1. File: contracts\contracts\core\connext\facets\BridgeFacet.sol (Line 492)

  2. File: contracts\contracts\core\connext\facets\BridgeFacet.sol (Line 492)

2. Missing checks for address(0x0) when assigning values to address state variables

Examples of this issue in the codebase:

  1. File: contracts\contracts\core\connext\helpers\Executor.sol (Line 48)

  2. File: contracts\contracts\core\connext\helpers\ConnextPriceOracle.sol (Line 77)

3. safeApprove is deprecated

Deprecated in favor of safeIncreaseAllowance() and safeDecreaseAllowance()

Example of this issue in the codebase:

  1. File: contracts\contracts\core\connext\libraries\AssetLogic.sol (Line 347)
jakekidd commented 2 years ago

1 has duplicate example 2.2 is invalid, 2.1 is fine

JeeberC4 commented 2 years ago

Multiple QA Reports submitted. Will not be judged.