search

code-423n4 / 2022-06-connext-findings

1 stars 0 forks source link

QA Report #251

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

1. FILE IS MISSING NATSPEC

Examples of this issue in the codebase:

  1. File: contracts\contracts\core\connext\libraries\LibDiamond.sol (Line 1)

2. NATSPEC IS INCOMPLETE

Examples of this issue in the codebase:

  1. File: contracts\contracts\core\connext\facets\BridgeFacet.sol (Line 627)

  2. File: contracts\contracts\core\connext\facets\BridgeFacet.sol (Line 636)

  3. File: contracts\contracts\core\connext\facets\BridgeFacet.sol (Line 706)

  4. File: contracts\contracts\core\connext\facets\BridgeFacet.sol (Line 719)

jakekidd commented 2 years ago

very barebones, 1st issue is invalid but valid that natspec missing @return here

JeeberC4 commented 2 years ago

Multiple QA Reports submitted. Will not be judged.