search

code-423n4 / 2022-06-connext-findings

1 stars 0 forks source link

QA Report #259

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

LOW

1. Title: Unused parameter in handle() function

https://github.com/code-423n4/2022-06-connext/blob/main/contracts/contracts/core/connext/facets/BridgeFacet.sol#L391

Make sure that all the parameters is used in the function or just remove it

2. Title: Set var to constant instead immutable

https://github.com/code-423n4/2022-06-connext/blob/main/contracts/contracts/core/connext/facets/VersionFacet.sol#L16

The value is set without constructor and hardcoded right at the declaration. Using constant is more accurate

jakekidd commented 2 years ago

1 is invalid, it's an implementation of an interface

2 is out of scope