Open code423n4 opened 2 years ago
1), 2) fixed
1) and 2) are actually invalid within the scope of this audit (there is no slippageTol
argument. It seems that the auditor was somehow looking at the wrong branch.
Regardless, it was a good find, and seems to have helped us?? ^ lol, I'm okay with keeping this for that reason
1) Description of AssetLogic._swapAsset lacks one input argument
AssetLogic._swapAsset() description has no mention of the _slippageTol argument:
Recommended Mitigation Steps
As an example:
2) Description of AssetLogic._swapAssetOut lacks one output argument
The success return value is omitted:
Recommended Mitigation Steps
As an example:
3) Open TODOs in BridgeFacet
Open TODO comments that require some decisions to be made and then code completion:
Also:
Recommended Mitigation Steps
Consider removing all TODO comments with the corresponding code amendments (i.e. fix, won't fix, etc) before release as they are relevant to the development process only.