code-423n4 / 2022-06-infinity-findings

4 stars 0 forks source link

QA Report #294

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

[NC - 01] InfinityToken: what is the used of EPOCH_CLIFF ?

EPOCH_CLIFF and EPOCH_DURATION are used in the same way, therefore either one should be removed, either comments should be clearer on their intended usage.


Especially EPOCH_CLIFF looks currently useless, unless it is intended to be larger than EPOCH_DURATION ? But in this case why not just increasing EPOCH_DURATION ?

HardlyDifficult commented 2 years ago

Merging with https://github.com/code-423n4/2022-06-infinity-findings/issues/275 and https://github.com/code-423n4/2022-06-infinity-findings/issues/287