code-423n4 / 2022-06-infinity-findings

4 stars 0 forks source link

QA Report #313

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Ensure that any fees set by the owner is less than 100%

https://github.com/code-423n4/2022-06-infinity/blob/765376fa238bbccd8b1e2e12897c91098c7e5ac6/contracts/core/InfinityExchange.sol#L1267

Create a constant variable to embody this value and when PROTOCOL_FEE_BPS is set, check that this number doesn't exceed the aforementioned (for eg, require (_protocolFeeBps<MIN_PROTOCOL_FEE)

Change mutability to constant since values will never change

The power level to stake thresholds remains unchanged:

https://github.com/code-423n4/2022-06-infinity/blob/main/contracts/staking/InfinityStaker.sol#L33-L42