L49/53/159/167 - The exitFees and entryFees variables can only have values between 1 and 10000, which represent 0.01% and 100%, but since it is not set in the constructor, the default value is 0, a value that is incorrect.
Recommended Mitigation Steps
It should be set in the constructor and set a correct value, otherwise it would generate an erroneous behavior.
Lines of code
https://github.com/code-423n4/2022-06-nested/blob/b4a153c943d54755711a2f7b80cbbf3a5bb49d76/contracts/NestedFactory.sol#L159 https://github.com/code-423n4/2022-06-nested/blob/b4a153c943d54755711a2f7b80cbbf3a5bb49d76/contracts/NestedFactory.sol#L167 https://github.com/code-423n4/2022-06-nested/blob/b4a153c943d54755711a2f7b80cbbf3a5bb49d76/contracts/NestedFactory.sol#L57
Vulnerability details
Impact
Recommended Mitigation Steps
It should be set in the constructor and set a correct value, otherwise it would generate an erroneous behavior.