search

code-423n4 / 2022-06-nested-findings

0 stars 1 forks source link

QA Report #14

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

https://github.com/code-423n4/2022-06-nested/blob/b4a153c943d54755711a2f7b80cbbf3a5bb49d76/contracts/governance/TimelockControllerEmergency.sol#L113

If the intention is for the Ether to be used, the function should call another function, otherwise it should revert. An unused receive() function enables the possibility for Ether to be locked in the contract.

obatirou commented 2 years ago

Disputed

This is a Timelock, the funds are not locked We can set the value to zero to not send ether. And if we made a mistake, we can create a script to send the ether back.

JeeberC4 commented 2 years ago

Warden submitted multiple QA Reports. Will not be judged.