search

code-423n4 / 2022-06-nested-findings

0 stars 1 forks source link

QA Report #18

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Non-critical Issues

  1. Constants should be defined rather than using magic numbers 2022-06-nested\contracts\NestedFactory.sol#L161 2022-06-nested\contracts\NestedFactory.sol#L169 2022-06-nested\contracts\NestedFactory.sol#L264 2022-06-nested\contracts\NestedFactory.sol#L378 2022-06-nested\contracts\NestedFactory.sol#L443 2022-06-nested\contracts\NestedFactory.sol#L629

  2. Natspec incomplete 2022-06-nested\contracts\NestedFactory.sol#L114 @return

2022-06-nested\contracts\operators\Beefy\lp\BeefyZapBiswapLPVaultOperator.sol#L232 @return

2022-06-nested\contracts\operators\Beefy\lp\BeefyZapBiswapLPVaultOperator.sol#L264 @param reserveA @param reserveB @param router @return

2022-06-nested\contracts\operators\Beefy\lp\BeefyZapUniswapLPVaultOperator.sol#L263 @param reserveA @param reserveB @param router @return

  1. Typo 2022-06-nested\contracts\NestedFactory.sol#L51 2022-06-nested\contracts\NestedFactory.sol#L639

Change "withdrawed" to "withdrew"

  1. Immutable addresses should be 0-checked 2022-06-nested\contracts\Withdrawer.sol#L17 2022-06-nested\contracts\operators\Yearn\YearnCurveVaultOperator.sol#L48-L50
Yashiru commented 2 years ago

1. Constants should be defined rather than using magic numbers (Duplicated)

Duplicated of #76 at 5. constants should be defined rather than using magic numbers

Yashiru commented 2 years ago

3. Typo (Duplicated)

Duplicated of #45 at Typos

obatirou commented 2 years ago

Natspec incomplete (duplicate)

https://github.com/code-423n4/2022-06-nested-findings/issues/84#issuecomment-1165712399