code-423n4 / 2022-06-nested-findings

0 stars 1 forks source link

QA Report #23

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

_sendValueWithFallbackWithdraw() instead of sendValue()

Contract should make use of _sendValueWithFallbackWithdraw() instead of sendValue(). This will ensure invalid transfers are correctly handled.

Instances:

contracts/Withdrawer.sol:29:        Address.sendValue(payable(msg.sender), amount);

Recommendation

Use _sendValueWithFallbackWithdraw() instead of sendValue()

obatirou commented 2 years ago

_sendValueWithFallbackWithdraw() instead of sendValue() (disputed)

Unknown function Warden could give more info ?

JeeberC4 commented 2 years ago

Warden submitted multiple QA Reports. Will not be judged.