Closed code423n4 closed 2 years ago
https://github.com/code-423n4/2022-06-nested/blob/b4a153c943d54755711a2f7b80cbbf3a5bb49d76/contracts/Withdrawer.sol#L27
ERC20 standard allows transferFrom/transfer function of some contracts to return bool or return nothing. Using safeTransfer/safeTransferFrom of SafeERC20.sol is recommended instead.
Affected code:
Duplicated of #24 at Use safeTransfer/safeTransferFrom consistently instead of transfer/transferFrom
Disagree with severity, must be a QA.
Lines of code
https://github.com/code-423n4/2022-06-nested/blob/b4a153c943d54755711a2f7b80cbbf3a5bb49d76/contracts/Withdrawer.sol#L27
Vulnerability details
Impact
ERC20 standard allows transferFrom/transfer function of some contracts to return bool or return nothing. Using safeTransfer/safeTransferFrom of SafeERC20.sol is recommended instead.
Affected code:
Proof of Concept
Tools Used
Recommended Mitigation Steps