code-423n4 / 2022-06-nested-findings

0 stars 1 forks source link

Gas Optimizations #87

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

[Gas - 01] Use Custom Errors

Instead of using error strings, to reduce deployment and runtime cost, you should use Custom Errors: see https://blog.soliditylang.org/2021/04/21/custom-errors/. This would save both deployment and runtime cost, and increase readability !

Examples: https://github.com/code-423n4/2022-06-nested/blob/b4a153c943d54755711a2f7b80cbbf3a5bb49d76/contracts/operators/Paraswap/ParaswapOperator.sol#L39 https://github.com/code-423n4/2022-06-nested/blob/b4a153c943d54755711a2f7b80cbbf3a5bb49d76/contracts/operators/ZeroEx/ZeroExOperator.sol#L33 And many others !

maximebrugel commented 2 years ago

[Gas - 01] Use Custom Errors (Duplicated)

6 (see comment)