QA Report

[code423n4]

Unnecessary Usage of transferFrom when transferring from address(this)

The code for transfering tokens in:

• Basket.sol:54
• Basket.sol:64
• Basket.sol:72

Uses transferFrom while it could simply use transfer, this will save gas (less calldata and less checks)

Lack of safeTransfer

The code for sweeping tokens in:

• Basket.sol:85
• Basket.sol:94

Is not using safeTransfer, hence doesn't check if the transfer was successful, which is inconsistent with the rest of the code

Variable Shadowing

In NibblVault.sol

The variable _totalSupply is part of ERC20Upgradeable but certain functions are shadowing it It may be best to rename it to avoid potential mistakes

[mundhrakeshav]

16

[HardlyDifficult]

Merging with https://github.com/code-423n4/2022-06-nibbl-findings/issues/272

[HardlyDifficult]

1) is invalid.