Closed code423n4 closed 2 years ago
I was the sponsor on that other contest you linked to here. I hate to disagree with myself, but accepting that as Medium was generous and probably shouldn't have been done.
Cryptopunks do not follow the ERC721 standard. It's a nice to have to include support for them here. Additionally wrappers already exist which could be used with this platform. Lowering the risk and merging with the warden's QA report https://github.com/code-423n4/2022-06-nibbl-findings/issues/297
Lines of code
https://github.com/code-423n4/2022-06-nibbl/blob/8c3dbd6adf350f35c58b31723d42117765644110/contracts/NibblVault.sol https://github.com/code-423n4/2022-06-nibbl/blob/8c3dbd6adf350f35c58b31723d42117765644110/contracts/Basket.sol
Vulnerability details
Impact
Cryptopunks are at the core of the NFT ecosystem. As one of the first NFTs, it embodies the culture of NFT marketplaces. By not supporting the cryptopunks, Nibbl is at a severe disadvantage when compared to other marketplaces. Cryptopunks have their own internal marketplace which allows users to trade their NFTs to other users. As such, cryptopunks does not adhere to the
ERC721
standard, it will always fail when the protocol attempts to trade them.Proof of Concept
Here is an example implementation of what it might look like to integrate cryptopunks into the protocol.
Tools Used
Manual.