search

code-423n4 / 2022-06-nibbl-findings

1 stars 0 forks source link

QA Report #65

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

DoS with failed call in Basket.sol

Impact

External calls can fail accidentally or deliberately, which can cause a DoS condition in the contract. To minimize the damage caused by such failures, it is better to isolate each external call into its own transaction that can be initiated by the recipient of the call. This is especially relevant for payments, where it is better to let users withdraw funds rather than push funds to them automatically (this also reduces the chance of problems with the gas limit).

Proof of Concept

CreationTX

{
  "address": "",
  "blockCoinbase": "0xcbcbcbcbcbcbcbcbcbcbcbcbcbcbcbcbcbcbcbcb",
  "blockDifficulty": "0xa7d7343662e26",
  "blockGasLimit": "0x7d0000",
  "blockNumber": "0x66e393",
  "blockTime": "0x5bfa4639",
  "calldata": "",
  "gasLimit": "0x7d000",
  "gasPrice": "0x773594000",
  "input": "0x60806040523480156200001157600080fd5b50604080518082018252600a8152691391950810985cdad95d60b21b60208083019182528351808501909452600484526327232a2160e11b90840152815191929162000060916000916200007f565b508051620000769060019060208401906200007f565b50505062000162565b8280546200008d9062000125565b90600052602060002090601f016020900481019282620000b15760008555620000fc565b82601f10620000cc57805160ff1916838001178555620000fc565b82800160010185558215620000fc579182015b82811115620000fc578251825591602001919060010190620000df565b506200010a9291506200010e565b5090565b5b808211156200010a57600081556001016200010f565b600181811c908216806200013a57607f821691505b602082108114156200015c57634e487b7160e01b600052602260045260246000fd5b50919050565b6126e480620001726000396000f3fe60806040526004361061016a5760003560e01c80637b9f76b5116100d1578063bc197c811161008a578063e985e9c511610064578063e985e9c514610463578063f225ef80146104ac578063f23a6e61146104cc578063f4f3b200146104ec57600080fd5b8063bc197c8114610403578063c87b56dd14610423578063d9e5389d1461044357600080fd5b80637b9f76b51461034e57806392e6b3441461036e57806395d89b411461038e5780639d6a890f146103a3578063a22cb465146103c3578063b88d4fde146103e357600080fd5b806323b872dd1161012357806323b872dd1461028057806342842e0e146102a05780636352211e146102c0578063690d8320146102e05780636f242ec81461030057806370a082311461032057600080fd5b806301ffc9a71461017657806306fdde03146101ab578063081812fc146101cd578063095ea7b314610205578063150b7a0214610227578063209602b91461026057600080fd5b3661017157005b600080fd5b34801561018257600080fd5b50610196610191366004611d70565b61050c565b60405190151581526020015b60405180910390f35b3480156101b757600080fd5b506101c0610538565b6040516101a29190611de5565b3480156101d957600080fd5b506101ed6101e8366004611df8565b6105ca565b6040516001600160a01b0390911681526020016101a2565b34801561021157600080fd5b50610225610220366004611e26565b610664565b005b34801561023357600080fd5b50610247610242366004611f09565b61077a565b6040516001600160e01b031990911681526020016101a2565b34801561026c57600080fd5b5061022561027b36600461200d565b6107db565b34801561028c57600080fd5b5061022561029b366004612042565b61099c565b3480156102ac57600080fd5b506102256102bb366004612042565b6109cd565b3480156102cc57600080fd5b506101ed6102db366004611df8565b6109e8565b3480156102ec57600080fd5b506102256102fb366004612083565b610a5f565b34801561030c57600080fd5b5061022561031b3660046120fb565b610af3565b34801561032c57600080fd5b5061034061033b366004612083565b610c6b565b6040519081526020016101a2565b34801561035a57600080fd5b50610225610369366004612173565b610cf2565b34801561037a57600080fd5b50610225610389366004612173565b610dd4565b34801561039a57600080fd5b506101c0610f20565b3480156103af57600080fd5b506102256103be366004612083565b610f2f565b3480156103cf57600080fd5b506102256103de3660046121b8565b610fa7565b3480156103ef57600080fd5b506102256103fe366004611f09565b610fb2565b34801561040f57600080fd5b5061024761041e3660046121f1565b610fe4565b34801561042f57600080fd5b506101c061043e366004611df8565b611045565b34801561044f57600080fd5b5061022561045e3660046120fb565b61112d565b34801561046f57600080fd5b5061019661047e36600461229f565b6001600160a01b03918216600090815260056020908152604080832093909416825291909152205460ff1690565b3480156104b857600080fd5b506102256104c7366004612173565b611349565b3480156104d857600080fd5b506102476104e73660046122cd565b6113ab565b3480156104f857600080fd5b50610225610507366004612083565b611406565b600061051782611548565b8061053257506001600160e01b031982166346cfc35960e11b145b92915050565b60606000805461054790612336565b80601f016020809104026020016040519081016040528092919081815260200182805461057390612336565b80156105c05780601f10610595576101008083540402835291602001916105c0565b820191906000526020600020905b8154815290600101906020018083116105a357829003601f168201915b5050505050905090565b6000818152600260205260408120546001600160a01b03166106485760405162461bcd60e51b815260206004820152602c60248201527f4552433732313a20617070726f76656420717565727920666f72206e6f6e657860448201526b34b9ba32b73a103a37b5b2b760a11b60648201526084015b60405180910390fd5b506000908152600460205260409020546001600160a01b031690565b600061066f826109e8565b9050806001600160a01b0316836001600160a01b031614156106dd5760405162461bcd60e51b815260206004820152602160248201527f4552433732313a20617070726f76616c20746f2063757272656e74206f776e656044820152603960f91b606482015260840161063f565b336001600160a01b03821614806106f957506106f9813361047e565b61076b5760405162461bcd60e51b815260206004820152603860248201527f4552433732313a20617070726f76652063616c6c6572206973206e6f74206f7760448201527f6e6572206e6f7220617070726f76656420666f7220616c6c0000000000000000606482015260840161063f565b6107758383611598565b505050565b6000836001600160a01b0316336001600160a01b03167fb6219d009b79f4e4fc9b2f61614df0c5340f2ae5a531b74cc33ddc09df5de8a8856040516107c191815260200190565b60405180910390a350630a85bd0160e11b5b949350505050565b6107e6336000611606565b6108025760405162461bcd60e51b815260040161063f90612371565b60005b8151811015610998578181815181106108205761082061239f565b60200260200101516001600160a01b031663a9059cbb338484815181106108495761084961239f565b60209081029190910101516040516370a0823160e01b81523060048201526001600160a01b03909116906370a0823190602401602060405180830381865afa158015610899573d6000803e3d6000fd5b505050506040513d601f19601f820116820180604052508101906108bd91906123b5565b6040516001600160e01b031960e085901b1681526001600160a01b03909216600483015260248201526044016020604051808303816000875af1158015610908573d6000803e3d6000fd5b505050506040513d601f19601f8201168201806040525081019061092c91906123ce565b50336001600160a01b03168282815181106109495761094961239f565b60200260200101516001600160a01b03167fa44616ec07d22ce15ebd7a567b7c16dd91a89f056f5e14f8ef7a6aa40a89b9b260405160405180910390a38061099081612401565b915050610805565b5050565b6109a63382611606565b6109c25760405162461bcd60e51b815260040161063f9061241c565b6107758383836116fc565b61077583838360405180602001604052806000815250610fb2565b6000818152600260205260408120546001600160a01b0316806105325760405162461bcd60e51b815260206004820152602960248201527f4552433732313a206f776e657220717565727920666f72206e6f6e657869737460448201526832b73a103a37b5b2b760b91b606482015260840161063f565b610a6a336000611606565b610a865760405162461bcd60e51b815260040161063f90612371565b6040516001600160a01b038216904780156108fc02916000818181858888f19350505050158015610abb573d6000803e3d6000fd5b506040516001600160a01b038216907ff6c62f95390a4a6ee24f778d79a6ce6e34dd01136e291fb3b7ff0fc1919540a290600090a250565b610afe336000611606565b610b1a5760405162461bcd60e51b815260040161063f90612371565b60005b8351811015610c6557838181518110610b3857610b3861239f565b60200260200101516001600160a01b03166342842e0e3084868581518110610b6257610b6261239f565b60209081029190910101516040516001600160e01b031960e086901b1681526001600160a01b0393841660048201529290911660248301526044820152606401600060405180830381600087803b158015610bbc57600080fd5b505af1158015610bd0573d6000803e3d6000fd5b50505050816001600160a01b0316848281518110610bf057610bf061239f565b60200260200101516001600160a01b03167f7d7d06fee8f280e47a7b6a0548f6dffbe5df52f1c1eb012a0d6a41f4a0f350c9858481518110610c3457610c3461239f565b6020026020010151604051610c4b91815260200190565b60405180910390a380610c5d81612401565b915050610b1d565b50505050565b60006001600160a01b038216610cd65760405162461bcd60e51b815260206004820152602a60248201527f4552433732313a2062616c616e636520717565727920666f7220746865207a65604482015269726f206164647265737360b01b606482015260840161063f565b506001600160a01b031660009081526003602052604090205490565b610cfd336000611606565b610d195760405162461bcd60e51b815260040161063f90612371565b604051632142170760e11b81523060048201526001600160a01b038281166024830152604482018490528416906342842e0e906064015b600060405180830381600087803b158015610d6a57600080fd5b505af1158015610d7e573d6000803e3d6000fd5b50505050806001600160a01b0316836001600160a01b03167f7d7d06fee8f280e47a7b6a0548f6dffbe5df52f1c1eb012a0d6a41f4a0f350c984604051610dc791815260200190565b60405180910390a3505050565b610ddf336000611606565b610dfb5760405162461bcd60e51b815260040161063f90612371565b604051627eeac760e11b8152306004820152602481018390526000906001600160a01b0385169062fdd58e90604401602060405180830381865afa158015610e47573d6000803e3d6000fd5b505050506040513d601f19601f82011682018060405250810190610e6b91906123b5565b604051637921219560e11b81529091506001600160a01b0385169063f242432a90610ea090309086908890879060040161246d565b600060405180830381600087803b158015610eba57600080fd5b505af1158015610ece573d6000803e3d6000fd5b505060408051868152602081018590526001600160a01b038087169450881692507ffb5471fdf60f5b676c3aab864f67d0be1f974c75f74cff7675295cfb339f9940910160405180910390a350505050565b60606001805461054790612336565b6000610f3b6001611898565b90508015610f53576006805461ff0019166101001790555b610f5e826000611922565b8015610998576006805461ff0019169055604051600181527f7f26b83ff96e1f2b6a682f133852f6798a09c465da95921460cefb38474024989060200160405180910390a15050565b610998338383611a64565b610fbc3383611606565b610fd85760405162461bcd60e51b815260040161063f9061241c565b610c6584848484611b2b565b6000846001600160a01b0316336001600160a01b03167f0d6928670f3243a6a17ef2c8e072419b0240bb3867270781e7a392cfb48cfd06868660405161102b9291906124ea565b60405180910390a35063bc197c8160e01b95945050505050565b6000818152600260205260409020546060906001600160a01b03166110c45760405162461bcd60e51b815260206004820152602f60248201527f4552433732314d657461646174613a2055524920717565727920666f72206e6f60448201526e3732bc34b9ba32b73a103a37b5b2b760891b606482015260840161063f565b60006110db60408051602081019091526000815290565b905060008151116110fb5760405180602001604052806000815250611126565b8061110584611b5e565b604051602001611116929190612518565b6040516020818303038152906040525b9392505050565b611138336000611606565b6111545760405162461bcd60e51b815260040161063f90612371565b60005b8351811015610c655760008482815181106111745761117461239f565b60200260200101516001600160a01b031662fdd58e3086858151811061119c5761119c61239f565b60200260200101516040518363ffffffff1660e01b81526004016111d59291906001600160a01b03929092168252602082015260400190565b602060405180830381865afa1580156111f2573d6000803e3d6000fd5b505050506040513d601f19601f8201168201806040525081019061121691906123b5565b905084828151811061122a5761122a61239f565b60200260200101516001600160a01b031663f242432a30858786815181106112545761125461239f565b6020026020010151856040518563ffffffff1660e01b815260040161127c949392919061246d565b600060405180830381600087803b15801561129657600080fd5b505af11580156112aa573d6000803e3d6000fd5b50505050826001600160a01b03168583815181106112ca576112ca61239f565b60200260200101516001600160a01b03167ffb5471fdf60f5b676c3aab864f67d0be1f974c75f74cff7675295cfb339f994086858151811061130e5761130e61239f565b60200260200101518460405161132e929190918252602082015260400190565b60405180910390a3508061134181612401565b915050611157565b611354336000611606565b6113705760405162461bcd60e51b815260040161063f90612371565b6040516323b872dd60e01b81523060048201526001600160a01b038281166024830152604482018490528416906323b872dd90606401610d50565b60408051848152602081018490526000916001600160a01b0387169133917fbbbe3754d41a9a88a068bdc1983426fa46ac272e729253f77bdb30956c951e4a910160405180910390a35063f23a6e6160e01b95945050505050565b611411336000611606565b61142d5760405162461bcd60e51b815260040161063f90612371565b6040516370a0823160e01b81523060048201526001600160a01b0382169063a9059cbb90339083906370a0823190602401602060405180830381865afa15801561147b573d6000803e3d6000fd5b505050506040513d601f19601f8201168201806040525081019061149f91906123b5565b6040516001600160e01b031960e085901b1681526001600160a01b03909216600483015260248201526044016020604051808303816000875af11580156114ea573d6000803e3d6000fd5b505050506040513d601f19601f8201168201806040525081019061150e91906123ce565b5060405133906001600160a01b038316907fa44616ec07d22ce15ebd7a567b7c16dd91a89f056f5e14f8ef7a6aa40a89b9b290600090a350565b60006001600160e01b031982166380ac58cd60e01b148061157957506001600160e01b03198216635b5e139f60e01b145b8061053257506301ffc9a760e01b6001600160e01b0319831614610532565b600081815260046020526040902080546001600160a01b0319166001600160a01b03841690811790915581906115cd826109e8565b6001600160a01b03167f8c5be1e5ebec7d5bd14f71427d1e84f3dd0314c0f7b2291e5b200ac8c7c3b92560405160405180910390a45050565b6000818152600260205260408120546001600160a01b031661167f5760405162461bcd60e51b815260206004820152602c60248201527f4552433732313a206f70657261746f7220717565727920666f72206e6f6e657860448201526b34b9ba32b73a103a37b5b2b760a11b606482015260840161063f565b600061168a836109e8565b9050806001600160a01b0316846001600160a01b031614806116d157506001600160a01b0380821660009081526005602090815260408083209388168352929052205460ff165b806107d35750836001600160a01b03166116ea846105ca565b6001600160a01b031614949350505050565b826001600160a01b031661170f826109e8565b6001600160a01b0316146117735760405162461bcd60e51b815260206004820152602560248201527f4552433732313a207472616e736665722066726f6d20696e636f72726563742060448201526437bbb732b960d91b606482015260840161063f565b6001600160a01b0382166117d55760405162461bcd60e51b8152602060048201526024808201527f4552433732313a207472616e7366657220746f20746865207a65726f206164646044820152637265737360e01b606482015260840161063f565b6117e0600082611598565b6001600160a01b0383166000908152600360205260408120805460019290611809908490612547565b90915550506001600160a01b038216600090815260036020526040812080546001929061183790849061255e565b909155505060008181526002602052604080822080546001600160a01b0319166001600160a01b0386811691821790925591518493918716917fddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef91a4505050565b600654600090610100900460ff16156118e1578160ff1660011480156118bd5750303b155b6118d95760405162461bcd60e51b815260040161063f90612576565b506000919050565b60065460ff8084169116106119085760405162461bcd60e51b815260040161063f90612576565b506006805460ff191660ff92909216919091179055600190565b6001600160a01b0382166119785760405162461bcd60e51b815260206004820181905260248201527f4552433732313a206d696e7420746f20746865207a65726f2061646472657373604482015260640161063f565b6000818152600260205260409020546001600160a01b0316156119dd5760405162461bcd60e51b815260206004820152601c60248201527f4552433732313a20746f6b656e20616c7265616479206d696e74656400000000604482015260640161063f565b6001600160a01b0382166000908152600360205260408120805460019290611a0690849061255e565b909155505060008181526002602052604080822080546001600160a01b0319166001600160a01b03861690811790915590518392907fddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef908290a45050565b816001600160a01b0316836001600160a01b03161415611ac65760405162461bcd60e51b815260206004820152601960248201527f4552433732313a20617070726f766520746f2063616c6c657200000000000000604482015260640161063f565b6001600160a01b03838116600081815260056020908152604080832094871680845294825291829020805460ff191686151590811790915591519182527f17307eab39ab6107e8899845ad3d59bd9653f200f220920489ca2b5937696c319101610dc7565b611b368484846116fc565b611b4284848484611c5c565b610c655760405162461bcd60e51b815260040161063f906125c4565b606081611b825750506040805180820190915260018152600360fc1b602082015290565b8160005b8115611bac5780611b9681612401565b9150611ba59050600a8361262c565b9150611b86565b60008167ffffffffffffffff811115611bc757611bc7611e52565b6040519080825280601f01601f191660200182016040528015611bf1576020820181803683370190505b5090505b84156107d357611c06600183612547565b9150611c13600a86612640565b611c1e90603061255e565b60f81b818381518110611c3357611c3361239f565b60200101906001600160f81b031916908160001a905350611c55600a8661262c565b9450611bf5565b60006001600160a01b0384163b15611d4f57604051630a85bd0160e11b81526001600160a01b0385169063150b7a0290611ca0903390899088908890600401612654565b6020604051808303816000875af1925050508015611cdb575060408051601f3d908101601f19168201909252611cd891810190612691565b60015b611d35573d808015611d09576040519150601f19603f3d011682016040523d82523d6000602084013e611d0e565b606091505b508051611d2d5760405162461bcd60e51b815260040161063f906125c4565b805181602001fd5b6001600160e01b031916630a85bd0160e11b1490506107d3565b5060016107d3565b6001600160e01b031981168114611d6d57600080fd5b50565b600060208284031215611d8257600080fd5b813561112681611d57565b60005b83811015611da8578181015183820152602001611d90565b83811115610c655750506000910152565b60008151808452611dd1816020860160208601611d8d565b601f01601f19169290920160200192915050565b6020815260006111266020830184611db9565b600060208284031215611e0a57600080fd5b5035919050565b6001600160a01b0381168114611d6d57600080fd5b60008060408385031215611e3957600080fd5b8235611e4481611e11565b946020939093013593505050565b634e487b7160e01b600052604160045260246000fd5b604051601f8201601f1916810167ffffffffffffffff81118282101715611e9157611e91611e52565b604052919050565b600082601f830112611eaa57600080fd5b813567ffffffffffffffff811115611ec457611ec4611e52565b611ed7601f8201601f1916602001611e68565b818152846020838601011115611eec57600080fd5b816020850160208301376000918101602001919091529392505050565b60008060008060808587031215611f1f57600080fd5b8435611f2a81611e11565b93506020850135611f3a81611e11565b925060408501359150606085013567ffffffffffffffff811115611f5d57600080fd5b611f6987828801611e99565b91505092959194509250565b600067ffffffffffffffff821115611f8f57611f8f611e52565b5060051b60200190565b600082601f830112611faa57600080fd5b81356020611fbf611fba83611f75565b611e68565b82815260059290921b84018101918181019086841115611fde57600080fd5b8286015b84811015612002578035611ff581611e11565b8352918301918301611fe2565b509695505050505050565b60006020828403121561201f57600080fd5b813567ffffffffffffffff81111561203657600080fd5b6107d384828501611f99565b60008060006060848603121561205757600080fd5b833561206281611e11565b9250602084013561207281611e11565b929592945050506040919091013590565b60006020828403121561209557600080fd5b813561112681611e11565b600082601f8301126120b157600080fd5b813560206120c1611fba83611f75565b82815260059290921b840181019181810190868411156120e057600080fd5b8286015b8481101561200257803583529183019183016120e4565b60008060006060848603121561211057600080fd5b833567ffffffffffffffff8082111561212857600080fd5b61213487838801611f99565b9450602086013591508082111561214a57600080fd5b50612157868287016120a0565b925050604084013561216881611e11565b809150509250925092565b60008060006060848603121561218857600080fd5b833561219381611e11565b925060208401359150604084013561216881611e11565b8015158114611d6d57600080fd5b600080604083850312156121cb57600080fd5b82356121d681611e11565b915060208301356121e6816121aa565b809150509250929050565b600080600080600060a0868803121561220957600080fd5b853561221481611e11565b9450602086013561222481611e11565b9350604086013567ffffffffffffffff8082111561224157600080fd5b61224d89838a016120a0565b9450606088013591508082111561226357600080fd5b61226f89838a016120a0565b9350608088013591508082111561228557600080fd5b5061229288828901611e99565b9150509295509295909350565b600080604083850312156122b257600080fd5b82356122bd81611e11565b915060208301356121e681611e11565b600080600080600060a086880312156122e557600080fd5b85356122f081611e11565b9450602086013561230081611e11565b93506040860135925060608601359150608086013567ffffffffffffffff81111561232a57600080fd5b61229288828901611e99565b600181811c9082168061234a57607f821691505b6020821081141561236b57634e487b7160e01b600052602260045260246000fd5b50919050565b6020808252601490820152731dda5d1a191c985dce9b9bdd08185b1b1bddd95960621b604082015260600190565b634e487b7160e01b600052603260045260246000fd5b6000602082840312156123c757600080fd5b5051919050565b6000602082840312156123e057600080fd5b8151611126816121aa565b634e487b7160e01b600052601160045260246000fd5b6000600019821415612415576124156123eb565b5060010190565b60208082526031908201527f4552433732313a207472616e736665722063616c6c6572206973206e6f74206f6040820152701ddb995c881b9bdc88185c1c1c9bdd9959607a1b606082015260800190565b6001600160a01b0394851681529290931660208301526040820152606081019190915260a060808201819052600190820152600360fc1b60c082015260e00190565b600081518084526020808501945080840160005b838110156124df578151875295820195908201906001016124c3565b509495945050505050565b6040815260006124fd60408301856124af565b828103602084015261250f81856124af565b95945050505050565b6000835161252a818460208801611d8d565b83519083019061253e818360208801611d8d565b01949350505050565b600082821015612559576125596123eb565b500390565b60008219821115612571576125716123eb565b500190565b6020808252602e908201527f496e697469616c697a61626c653a20636f6e747261637420697320616c72656160408201526d191e481a5b9a5d1a585b1a5e995960921b606082015260800190565b60208082526032908201527f4552433732313a207472616e7366657220746f206e6f6e20455243373231526560408201527131b2b4bb32b91034b6b83632b6b2b73a32b960711b606082015260800190565b634e487b7160e01b600052601260045260246000fd5b60008261263b5761263b612616565b500490565b60008261264f5761264f612616565b500690565b6001600160a01b038581168252841660208201526040810183905260806060820181905260009061268790830184611db9565b9695505050505050565b6000602082840312156126a357600080fd5b815161112681611d5756fea2646970667358221220c6ab3965ec82e1beda1f2973efe8411c2786fe950ce220df5af7841e99a1ec9364736f6c634300080a0033",
  "name": "unknown",
  "origin": "0xaffeaffeaffeaffeaffeaffeaffeaffeaffeaffe",
  "value": "0x0",
  "hasName": false,
  "failedToParse": true,
  "humanReadableInstruction": "Unable to decode"
}

call initialise

{
  "address": "0x901d12ebe1b195e5aa8748e62bd7734ae19b51f",
  "blockCoinbase": "0xcbcbcbcbcbcbcbcbcbcbcbcbcbcbcbcbcbcbcbcb",
  "blockDifficulty": "0xa7d7343662e26",
  "blockGasLimit": "0x7d0000",
  "blockNumber": "0x66e393",
  "blockTime": "0x5bfa4639",
  "calldata": "0x9d6a890f000000000000000000000000affeaffeaffeaffeaffeaffeaffeaffeaffeaffe",
  "gasLimit": "0x7d000",
  "gasPrice": "0x773594000",
  "input": "0x9d6a890f000000000000000000000000affeaffeaffeaffeaffeaffeaffeaffeaffeaffe",
  "name": "initialise(address)",
  "origin": "0xaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
  "value": "0x0",
  "decodedInput": "initialise(0xaffeaffeaffeaffeaffeaffeaffeaffeaffeaffe)",
  "hasDecodedInput": "initialise(0xaffeaffeaffeaffeaffeaffeaffeaffeaffeaffe)",
  "hasName": true,
  "failedToParse": false,
  "humanReadableInstruction": "initialise(0xaffeaffeaffeaffeaffeaffeaffeaffeaffeaffe)"
}

call withdrawERC1155

{
  "address": "0x901d12ebe1b195e5aa8748e62bd7734ae19b51f",
  "blockCoinbase": "0xcbcbcbcbcbcbcbcbcbcbcbcbcbcbcbcbcbcbcbcb",
  "blockDifficulty": "0xa7d7343662e26",
  "blockGasLimit": "0x7d0000",
  "blockNumber": "0x66e393",
  "blockTime": "0x5bfa4639",
  "calldata": "0x92e6b344000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
  "gasLimit": "0x7d000",
  "gasPrice": "0x773594000",
  "input": "0x92e6b344000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
  "name": "withdrawERC1155(address,uint256,address)",
  "origin": "0xaffeaffeaffeaffeaffeaffeaffeaffeaffeaffe",
  "value": "0x0",
  "decodedInput": "withdrawERC1155(0x0000000000000000000000000000000000000000, 0, 0x0000000000000000000000000000000000000000)",
  "hasDecodedInput": "withdrawERC1155(0x0000000000000000000000000000000000000000, 0, 0x0000000000000000000000000000000000000000)",
  "hasName": true,
  "failedToParse": false,
  "humanReadableInstruction": "withdrawERC1155(0x0000000000000000000000000000000000000000, 0, 0x0000000000000000000000000000000000000000)"
}

Tools Used

mythx

Recommended Mitigation Steps

It is recommended to follow call best practices:

HardlyDifficult commented 2 years ago

This does not appear to be actionable feedback. e.g. withdrawERC1155 only acts on inputs provided -- so what should be done differently here? Without additional context this seems to be invalid.