code-423n4 / 2022-06-notional-coop-findings

1 stars 1 forks source link

cause users to revet right after deployment so they cant lend or borrow #197

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Lines of code

https://github.com/code-423n4/2022-06-notional-coop/blob/main/notional-wrapped-fcash/contracts/wfCashBase.sol#L83-L90 https://github.com/code-423n4/2022-06-notional-coop/blob/6f8c325f604e2576e2fe257b6b57892ca181509a/notional-wrapped-fcash/contracts/wfCashLogic.sol#L57

Vulnerability details

Impact

because of deployment hasMatured is false mintInternal reverts then cause users' to loose money on gas and users' cant lend which could lead to worse things and cause more attack vectors.

Recommended Mitigation Steps

check for delay after deployment or get the value from block.timestamp and make function to increase it by x on deployment

jeffywu commented 2 years ago

I don't understand the report