search

code-423n4 / 2022-06-notional-coop-findings

1 stars 1 forks source link

QA Report #199

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

1-. No indexed event parameters

a. Summary: Event not using indexed parameters. This could make it harder and inefficient for off-chain tools to analyse them.

b. Details: Indexed parameters (“topics”) are searchable event parameters. They are stored separately from unindexed event parameters in an efficient manner to allow for faster access. This is useful for efficient off-chain-analysis, but it is also more costly gas-wise.

c. Github Permalinks: https://github.com/code-423n4/2022-06-notional-coop/blob/main/notional-wrapped-fcash/contracts/proxy/WrappedfCashFactory.sol#L15

d. Mitigation: Consider which event parameters could be particularly useful to off-chain tools and should be indexed.

gzeoneth commented 2 years ago

Duplicate #131 by the same warden.