// Mapping for a set token, wether or not to redeem to underlying upon reaching maturity
wether instead of Whether
Lack of consistency in using uint256 and uint
some variables have been declared using uint while others are explicitly using uint256. I suggest sticking to one as they both mean the same thing
Function _getFCashPositions uses both uint and uint256 and also majority of the other variables in the contract are using uint256
Then inside the loop within this function we use uint256
for(uint256 i = 0; i < positionsLength; i++) {
Also outside this function most of the other variables are using uint256
Lock pragmas to specific compiler version
Contracts should be deployed with the same compiler version and flags that they have been tested the most with. Locking the pragma helps ensure that contracts do not accidentally get deployed using, for example, the latest compiler which may have higher risks of undiscovered bugs. Contracts may also be deployed by others and the pragma indicates the compiler version intended by the original authors.
Natspec is incomplete
File: NotionalTradeModule.sol line 175
https://github.com/code-423n4/2022-06-notional-coop/blob/6f8c325f604e2576e2fe257b6b57892ca181509a/index-coop-notional-trade-module/contracts/protocol/modules/v1/NotionalTradeModule.sol#L175-L196
Missing @return
File: NotionalTradeModule.sol line 352-358
https://github.com/code-423n4/2022-06-notional-coop/blob/6f8c325f604e2576e2fe257b6b57892ca181509a/index-coop-notional-trade-module/contracts/protocol/modules/v1/NotionalTradeModule.sol#L352-L358
Missing @return
TYPOS
File: NotionalTradeModule.sol line 215
MANGER instead of MANAGER
File: NotionalTradeModule.sol line 416
Alo Instead of Also
File: NotionalTradeModule.sol line 455
Alo Instead of Also
File: NotionalTradeModule.sol line 111
wether instead of Whether
Lack of consistency in using uint256 and uint
some variables have been declared using uint while others are explicitly using uint256. I suggest sticking to one as they both mean the same thing Function _getFCashPositions uses both uint and uint256 and also majority of the other variables in the contract are using uint256
line 602-603
Then inside the loop within this function we use uint256
Also outside this function most of the other variables are using uint256
Lock pragmas to specific compiler version
Contracts should be deployed with the same compiler version and flags that they have been tested the most with. Locking the pragma helps ensure that contracts do not accidentally get deployed using, for example, the latest compiler which may have higher risks of undiscovered bugs. Contracts may also be deployed by others and the pragma indicates the compiler version intended by the original authors.
File: wfCashERC4626.sol line 2