search

code-423n4 / 2022-06-notional-coop-findings

1 stars 1 forks source link

QA Report #233

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Usage of pragma experimental ABIEncoderV2

Details: Consider removing L3 of wfCashLogic.sol, as:

  1. ABIEncoderV2 is not considered experimental anymore since Solidity 0.7.4; and
  2. ABIEncoderV2 is turned on by default since Solidity 0.8.0.

Usage of deprecated function safeApprove

Details: In L66-75 of wfCashBase.sol the function safeApprove from OpenZeppelin contracts are used, however these functions have been deprecated according to OpenZeppelin 4.x docs.