code-423n4 / 2022-06-notional-coop-findings

1 stars 1 forks source link

Upgraded Q -> H from 222 [1656255302682] #236

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Judge has assessed an item in Issue #222 as High risk. The relevant finding follows:

[L-02] totalAssets of erc4626 should never revert

eip-4626 According to the spec, totalAssets of erc4626 should never revert

MUST NOT revert. wfcash would revert if it's matured but hasn't settled. wfCashERC4626.sol#L23

gzeoneth commented 2 years ago

Duplicate of https://github.com/code-423n4/2022-06-notional-coop-findings/issues/155

gzeoneth commented 2 years ago

Considering this as a duplicate of https://github.com/code-423n4/2022-06-notional-coop-findings/issues/88 by the same warden. Not exactly a duplicate but decided to consolidate all 4626 related issue.