search

code-423n4 / 2022-06-putty-findings

5 stars 0 forks source link

Use a reentrancy guard #198

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Lines of code

https://github.com/OpenZeppelin/openzeppelin-contracts/blob/5fbf494511fd522b931f7f92e2df87d671ea8b0b/contracts/security/ReentrancyGuard.sol#L22

Vulnerability details

Use a reentrancy guard on functions that have the team has lower confidence in their ability to fend off reentrancy attacks

rotcivegaf commented 2 years ago

I don't see a possibility of a reentrancy attack but Sneakyninja0129 shows some scenario where it is possible

outdoteth commented 2 years ago

No exploit is given

HickupHH3 commented 2 years ago

Merely best practice, no context given. Non-crit QA. This shall be warden's primary report since none was submitted.