search

code-423n4 / 2022-06-putty-findings

5 stars 0 forks source link

QA Report #336

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

QA1 : payable should only be marked for functions that guarantee to revert for normal user like with onlyOwner modifier, else it's best to add withdraw function to prevent token locks sent by mistake.

https://github.com/code-423n4/2022-06-putty/blob/3b6b844bc39e897bd0bbb69897f2deff12dc3893/contracts/src/PuttyV2.sol#L573-L577

HickupHH3 commented 2 years ago

invalid, payable is required in this function as ETH is a valid payment token.