Open code423n4 opened 2 years ago
When checking whether position has expired or not, none includes ==
https://github.com/code-423n4/2022-06-putty/blob/3b6b844bc39e897bd0bbb69897f2deff12dc3893/contracts/src/PuttyV2.sol#L401 https://github.com/code-423n4/2022-06-putty/blob/3b6b844bc39e897bd0bbb69897f2deff12dc3893/contracts/src/PuttyV2.sol#L481
do either require(block.timestamp <= positionExpirations[uint256(orderHash)], "Position has expired"); on L#401 or require(block.timestamp >= positionExpirations[longPositionId] || isExercised, "Must be exercised or expired"); L#481
When checking whether position has expired or not, none includes ==
https://github.com/code-423n4/2022-06-putty/blob/3b6b844bc39e897bd0bbb69897f2deff12dc3893/contracts/src/PuttyV2.sol#L401 https://github.com/code-423n4/2022-06-putty/blob/3b6b844bc39e897bd0bbb69897f2deff12dc3893/contracts/src/PuttyV2.sol#L481
do either require(block.timestamp <= positionExpirations[uint256(orderHash)], "Position has expired"); on L#401 or require(block.timestamp >= positionExpirations[longPositionId] || isExercised, "Must be exercised or expired"); L#481