search

code-423n4 / 2022-06-putty-findings

5 stars 0 forks source link

Upgraded Q -> M from 417 [1657509638642] #437

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

Judge has assessed an item in Issue #417 as Medium risk. The relevant finding follows:

HickupHH3 commented 1 year ago

(L2) fee only for call orders The protocol collects a fee proportional to the strike. In the current implementation, this happens only during the withdraw of a exercised call order (or unexercised put) (lines). I think there should be a fee also for the other order, but it got missing.

Recommendations Add a similar fee collection during exercise of a put order. Overall, check all possible paths and look if the fees collected make sense.

dup of #285