search

code-423n4 / 2022-06-putty-findings

5 stars 0 forks source link

Upgraded Q -> M from 118 [1657878801501] #447

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Judge has assessed an item in Issue #118 as Medium risk. The relevant finding follows:

HickupHH3 commented 2 years ago

PuttyV2.fillOrder() might revert when order.premium = 0. I think it's possible premium = 0 and zero tranfer might be failed for some ERC20 tokens from this https://github.com/code-423n4/2022-05-sturdy-findings/issues/79. We should check premium != 0 before transfer. https://github.com/code-423n4/2022-06-putty/blob/3b6b844bc39e897bd0bbb69897f2deff12dc3893/contracts/src/PuttyV2.sol#L324 https://github.com/code-423n4/2022-06-putty/blob/3b6b844bc39e897bd0bbb69897f2deff12dc3893/contracts/src/PuttyV2.sol#L338

dup of #283