search

code-423n4 / 2022-06-putty-findings

5 stars 0 forks source link

Upgraded Q -> M from 253 [1657932408647] #459

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Judge has assessed an item in Issue #253 as Medium risk. The relevant finding follows:

HickupHH3 commented 2 years ago
  1. Not Support Cryptopunk or Cryptokitties Tokens While the PuttyV2 contract is compatible with standard ERC20 and ERC721 tokens, it is not able to handle popular non-standard ERC721 tokens such as cryptopunks. The typical transferFrom() call will fail.

Recommended Mitigation Steps NFTX protocol has implemented a way to handle the transfer of both standard and non-standard ERC721 tokens. The relevant implementation can be found here.

dup of #16