search

code-423n4 / 2022-06-putty-findings

5 stars 0 forks source link

Upgraded Q -> M from 190 [1657955157754] #466

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

Judge has assessed an item in Issue #190 as Medium risk. The relevant finding follows:

HickupHH3 commented 1 year ago

Orders with too many assets or too many whitelisted can remain impossible to fulfill due to block gas limit Some orders might not get fulfilled if they have too many assets or too many whitelisted addresses. As the number of assets or whitelisted addresses increase, it is possible to reach block gas limit inside the loops, hence there would be DOS on the order. This can cause naive users to waste gas trying to fulfill orders.

Make sure the frontend does not accept creating orders with greater than certain amount of assets and whitelisted addresses.

dup of #227