search

code-423n4 / 2022-06-yieldy-findings

0 stars 0 forks source link

QA Report #302

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

[L-01] Duplicate code block https://github.com/code-423n4/2022-06-yieldy/blob/524f3b83522125fb7d4677fa7a7e5ba5a2c0fe67/src/contracts/Staking.sol#L84-L91

Approving twice with the same parameters - redundant and gas consuming.

[N-01] Using V1 token name FOX in comments where is not appropriate https://github.com/code-423n4/2022-06-yieldy/blob/524f3b83522125fb7d4677fa7a7e5ba5a2c0fe67/src/contracts/Staking.sol#L138 https://github.com/code-423n4/2022-06-yieldy/blob/524f3b83522125fb7d4677fa7a7e5ba5a2c0fe67/src/contracts/Staking.sol#L367

toshiSat commented 2 years ago

sponsor approved