function contractId() public pure returns (bytes32) {
return keccak256('xc20-wrapper');
}
constants should be defined rather than using magic numbers
There are several occurrences of literal values with unexplained meaning .Literal values in the codebase without an explained meaning make the code harder to read, understand and maintain, thus hindering the experience of developers, auditors and external contributors alike.
Developers should define a constant variable for every magic value used , giving it a clear and self-explanatory name.
QA
Missing checks for address(0x0) when assigning values to address state variables
File: DepositBase.sol line 24
File: XC20Wrapper.sol line 27
public functions not called by the contract should be declared external instead
File: DepositBase.sol line 41
File: XC20Wrapper.sol line 40-42
constants should be defined rather than using magic numbers
There are several occurrences of literal values with unexplained meaning .Literal values in the codebase without an explained meaning make the code harder to read, understand and maintain, thus hindering the experience of developers, auditors and external contributors alike.
Developers should define a constant variable for every magic value used , giving it a clear and self-explanatory name.
File: DepositBase.sol line 50 0xff
File: DepositBase.sol line 37 0xff
Typos
File: ReceiverImplementation.sol line 37
trough instead of through