search

code-423n4 / 2022-07-axelar-findings

0 stars 0 forks source link

QA Report #215

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

N-1 public functions not called by the contract should be declared external instead Contracts are allowed to override their parents' functions and change the visibility from external to public. [XC20Wrapper.sol L#40](]https://github.com/code-423n4/2022-07-axelar/blob/main/xc20/contracts/XC20Wrapper.sol#:~:text=function%20contractId()%20public%20pure%20returns%20(bytes32)%20%7B) [DepositBase.sol L#41](https://github.com/code-423n4/2022-07-axelar/blob/main/contracts/deposit-service/DepositBase.sol#:~:text=function%20wrappedToken()%20public%20view%20returns%20(address)%20%7B)

N-2 Incorrect Comment AxelarGAteway.sol L#29

GalloDaSballo commented 2 years ago

N-1 public functions not called by the contract should be declared external instead

Disputed

Screenshot 2022-08-28 at 22 40 11

N-2 Incorrect Comment

NC