code-423n4 / 2022-07-axelar-findings

0 stars 0 forks source link

QA Report #228

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

https://github.com/code-423n4/2022-07-axelar/blob/9c4c44b94cddbd48b9baae30051a4e13cbe39539/contracts/AxelarGateway.sol#L342 https://github.com/code-423n4/2022-07-axelar/blob/9c4c44b94cddbd48b9baae30051a4e13cbe39539/contracts/AxelarGateway.sol#L298 https://github.com/code-423n4/2022-07-axelar/blob/9c4c44b94cddbd48b9baae30051a4e13cbe39539/contracts/AxelarGateway.sol#L540 https://github.com/code-423n4/2022-07-axelar/blob/9c4c44b94cddbd48b9baae30051a4e13cbe39539/contracts/AxelarGateway.sol#L544 https://github.com/code-423n4/2022-07-axelar/blob/9c4c44b94cddbd48b9baae30051a4e13cbe39539/contracts/AxelarGateway.sol#L548 https://github.com/code-423n4/2022-07-axelar/blob/9c4c44b94cddbd48b9baae30051a4e13cbe39539/contracts/AxelarGateway.sol#L552 https://github.com/code-423n4/2022-07-axelar/blob/9c4c44b94cddbd48b9baae30051a4e13cbe39539/contracts/AxelarGateway.sol#L556

The parameter of the abi.encodePacked function is of variable type with variable length, so using the abi.encodePacked function will make the code susceptible to Hash collisions error.

GalloDaSballo commented 2 years ago

I'm going to assume the warden is new

You can't just copy paste a report from another contest, * search for abi.encodePacked and then assume the report is valid.

If you cannot produce any clashing of hashes, the submission is invalid

The time you can produce such collision, feel free to submit with higher severity.

In this case, the finding is invalid and as such I'll close the report