search

code-423n4 / 2022-07-axelar-findings

0 stars 0 forks source link

QA Report #6

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Add Reentrancy Guard to Multiple Functions to Receiver Implementation Contract.

https://github.com/code-423n4/2022-07-axelar/blob/main/contracts/deposit-service/ReceiverImplementation.sol

re1ro commented 2 years ago

Invalid ReceiverImplementation is used by the DepositReceiver which is deployed and destroyed immediately. There is nowhere to reenter

GalloDaSballo commented 2 years ago

Because the finding points towards the breaking of CEI pattern I believe It's correct to leave as valid Low.

However the submission is really underwhelming and should be penalized

GalloDaSballo commented 2 years ago

1L

re1ro commented 2 years ago

Again DepositReceiver that is using ReceiverImplementation doesn't have any methods besides constructor. So there is literally nowhere to re-enter. Still invalid from our point of view