Underflow

[code423n4]

Lines of code

https://github.com/code-423n4/2022-07-fractional/blob/8f2697ae727c60c93ea47276f8fa128369abfe51/src/interfaces/IMinter.sol#L2-L10

Vulnerability details

Impact

A detailed description of the impact of this finding.

Underflow

• It is possible to cause an arithmetic underflow.

Proof of Concept

Provide direct links to all referenced code on GitHub. Add screenshots, logs, or any other relevant proof that illustrates the concept.

https://github.com/code-423n4/2022-07-fractional/blob/8f2697ae727c60c93ea47276f8fa128369abfe51/src/interfaces/IMinter.sol#L2-L10

Tools Used

Mythx

Recommended Mitigation Steps

• Prevent the underflow by constraining inputs using the require() statement or using the OpenZeppelin SafeMath library for integer arithmetic operations.

  • SafeMath: https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/utils/math/SafeMath.sol

    • Refer to the transaction trace generated for this issue to reproduce the underflow.

[stevennevins]

0 - Non Bug

No possibility to underflow here

[HardlyDifficult]

Not enough information was provided to judge this report. Closing as invalid.