The use of the deprecated transfer() function for an address will inevitably make the transaction fail when:
The claimer smart contract does not implement a payable function.
The claimer smart contract does implement a payable fallback which uses more than 2300 gas unit.
The claimer smart contract implements a payable fallback function that needs less than 2300 gas units but is called through proxy, raising the call’s gas usage above 2300.
Additionally, using higher than 2300 gas might be mandatory for some multisig wallets.
Tools Used
VS Code
Recommended Mitigation Steps
It is recommended to use call instead of transfer. As a code reference, you may refer to the Openzeppelin Address.sendValue implementation.
Lines of code
https://github.com/code-423n4/2022-07-fractional/blob/8f2697ae727c60c93ea47276f8fa128369abfe51/src/modules/Migration.sol#L172 https://github.com/code-423n4/2022-07-fractional/blob/8f2697ae727c60c93ea47276f8fa128369abfe51/src/modules/Migration.sol#L325
Vulnerability details
This is a classic Code4rena issue:
Impact
The use of the deprecated
transfer()
function for an address will inevitably make the transaction fail when:Additionally, using higher than 2300 gas might be mandatory for some multisig wallets.
Tools Used
VS Code
Recommended Mitigation Steps
It is recommended to use
call
instead oftransfer
. As a code reference, you may refer to the OpenzeppelinAddress.sendValue
implementation.