The use of the deprecated transfer() function for an address will inevitably make the transaction fail when:
The claimer smart contract does not implement a payable function.
The claimer smart contract does implement a payable fallback which uses more than 2300 gas unit.
The claimer smart contract implements a payable fallback function that needs less than 2300 gas units but is called through proxy, raising the call's gas usage above 2300.
Additionally, using higher than 2300 gas might be mandatory for some multisig wallets.
Proof of Concept
function payEther(uint256 payAmt, address payAddress) internal {
if (payAmt > 0) {
// if royalty has to be paid
payable(payAddress).transfer(payAmt); // royalty transfer to royaltyaddress
}
}
Lines of code
https://github.com/code-423n4/2022-07-golom/blob/e5efa8f9d6dda92a90b8b2c4902320acf0c26816/contracts/core/GolomTrader.sol#L154
Vulnerability details
Impact
The use of the deprecated transfer() function for an address will inevitably make the transaction fail when:
Additionally, using higher than 2300 gas might be mandatory for some multisig wallets.
Proof of Concept
Tools Used
VSC
Recommended Mitigation Steps
I recommend using call() instead of transfer()