call() should be used instead of transfer() on an address payable

[code423n4]

Lines of code

https://github.com/code-423n4/2022-07-golom/blob/7bbb55fca61e6bae29e57133c1e45806cbb17aa4/contracts/core/GolomTrader.sol#L154

Vulnerability details

Lines of Code:

https://github.com/code-423n4/2022-07-golom/blob/7bbb55fca61e6bae29e57133c1e45806cbb17aa4/contracts/core/GolomTrader.sol#L154

Vulnerability Details:

This is a classic Code4rena issue: 1) code-423n4/2021-04-meebits-findings#2 2) code-423n4/2021-10-tally-findings#20 3) code-423n4/2022-01-openleverage-findings#75

Impact

The use of the deprecated transfer() function for an address will inevitably make the transaction fail when:

1) The claimer smart contract does not implement a payable function. 2) The claimer smart contract does implement a payable fallback which uses more than 2300 gas unit. 3) The claimer smart contract implements a payable fallback function that needs less than 2300 gas units but is called through proxy, raising the call’s gas usage above 2300.

Additionally, using higher than 2300 gas might be mandatory for some multisig wallets.

Proof of Concept

https://github.com/code-423n4/2022-07-golom/blob/7bbb55fca61e6bae29e57133c1e45806cbb17aa4/contracts/core/GolomTrader.sol#L154

payable(payAddress).transfer(payAmt);

Tools Used

Manual code review

Recommended Mitigation Steps

I recommend using call() instead of transfer().

[KenzoAgada]

Duplicate of #343