The use of the deprecated transfer() function for an address will inevitably make the transaction fail when:
-The claimer smart contract does not implement a payable function.
-The claimer smart contract does implement a payable fallback which uses more than 2300 gas unit.
-The claimer smart contract implements a payable fallback function that needs less than 2300 gas units but is called through proxy, raising the call’s
gas usage above 2300.
Additionally, using higher than 2300 gas might be mandatory for some multisig wallets.
KenzoAgada
commented
2 years ago
Lines of code
https://github.com/code-423n4/2022-07-golom/blob/7bbb55fca61e6bae29e57133c1e45806cbb17aa4/contracts/core/GolomTrader.sol#L154
Vulnerability details
Impact
The use of the deprecated transfer() function for an address will inevitably make the transaction fail when:
-The claimer smart contract does not implement a payable function. -The claimer smart contract does implement a payable fallback which uses more than 2300 gas unit. -The claimer smart contract implements a payable fallback function that needs less than 2300 gas units but is called through proxy, raising the call’s gas usage above 2300. Additionally, using higher than 2300 gas might be mandatory for some multisig wallets.
Proof of Concept
I am not 100% clear about this, but i saw it in an other report from a contest before https://code4rena.com/reports/2022-04-backd/#m-01-call-should-be-used-instead-of-transfer-on-an-address-payable
Tools Used
No tools used for this
Recommended Mitigation Steps
I recommend using call() instead of transfer().